Adding support for AppRTC closure compiling.

Adding support for AppRTC closure compiling.

Since AppRTC now uses Closure we need to be able to closure compile.
This is implemented as a grunt task, which means we need grunt, which
means we need node and npm. This patch makes sure to download all the
necessary dependencies and invokes them locally, which means we don't
need to install stuff on the bots. A risk here is increased flakes
since many of these tools (like npm) download stuff in a manner that
likely isn't reliable. I suggest we check how it works out and add
retry mechanisms as necessary.

This checks in node versions
node-v0.10.35-darwin-x64.tar.gz
node-v0.10.35-linux-x64.tar.gz
npm-1.4.9.zip / v0.10.36/x64/node.exe

into source control.

BUG=451985
R=kjellander@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/293821

[phoglund_chromium, 2015-01-27 09:12:43]

phoglund@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2015-01-27 09:32:57]

Some comments.

Please update the CL description with the versions of node and npm that are
bundled in the Google storage files, so we can have some traceability for the
future.

https://codereview.chromium.org/872423002/diff/20001/build_apprtc_closure.py
File build_apprtc_closure.py (right):

https://codereview.chromium.org/872423002/diff/20001/build_apprtc_closure.py#...
build_apprtc_closure.py:2: # Copyright 2014 The Chromium Authors. All rights
reserved.
2015

https://codereview.chromium.org/872423002/diff/20001/download_node.py
File download_node.py (right):

https://codereview.chromium.org/872423002/diff/20001/download_node.py#newcode2
download_node.py:2: # Copyright 2014 The Chromium Authors. All rights reserved.
2015

https://codereview.chromium.org/872423002/diff/20001/download_node.py#newcode40
download_node.py:40: webrtc_deps_path = argv[1]
A lot of this is duplicated in download_golang.py. I think you could extract a
helper function to put in utils.py, but I'll leave that as an optional
improvement.

https://codereview.chromium.org/872423002/diff/20001/download_node.py#newcode48
download_node.py:48: or not os.path.exists('node')):
Do you need to check for non-existing node dir here? 
utils.ComputeSHA1 will return 0 for non-existing archive (which is how the
download_golang.py deals with that case).

[phoglund_chromium, 2015-01-27 09:39:54]

On 2015/01/27 09:32:57, kjellander wrote:
> Some comments.
> 
> Please update the CL description with the versions of node and npm that are
> bundled in the Google storage files, so we can have some traceability for the
> future.
> 

Good idea, done. I considered putting version info in the archive filenames but
that would
be a maintenance problem in the future. I hope we won't have to update these
very often.

[phoglund_chromium, 2015-01-27 09:49:38]

PTAL

https://codereview.chromium.org/872423002/diff/20001/build_apprtc_closure.py
File build_apprtc_closure.py (right):

https://codereview.chromium.org/872423002/diff/20001/build_apprtc_closure.py#...
build_apprtc_closure.py:2: # Copyright 2014 The Chromium Authors. All rights
reserved.
On 2015/01/27 09:32:56, kjellander wrote:
> 2015

Done.

https://codereview.chromium.org/872423002/diff/20001/download_node.py
File download_node.py (right):

https://codereview.chromium.org/872423002/diff/20001/download_node.py#newcode2
download_node.py:2: # Copyright 2014 The Chromium Authors. All rights reserved.
On 2015/01/27 09:32:57, kjellander wrote:
> 2015

Done.

https://codereview.chromium.org/872423002/diff/20001/download_node.py#newcode40
download_node.py:40: webrtc_deps_path = argv[1]
On 2015/01/27 09:32:56, kjellander wrote:
> A lot of this is duplicated in download_golang.py. I think you could extract a
> helper function to put in utils.py, but I'll leave that as an optional
> improvement.

Yes, I feel a lot of the duplication is incidental, and I think there's a
possibility these will diverge anyway. I would have a hard time naming the
helper function
(DownloadArchivesWithAutoPlatformIfNecessaryAndUnpackAndReplaceWithVersionNumberStrippedFromArchiveName)?

https://codereview.chromium.org/872423002/diff/20001/download_node.py#newcode48
download_node.py:48: or not os.path.exists('node')):
On 2015/01/27 09:32:57, kjellander wrote:
> Do you need to check for non-existing node dir here? 
> utils.ComputeSHA1 will return 0 for non-existing archive (which is how the
> download_golang.py deals with that case).

Ah, I should do this in download_golang too. The problem is mainly during
development if the archive gets downloaded but not unpacked, the script will do
nothing and leave us in a bad state which must be recovered from manually. I
added that check out of convenience and in case the bots get into that state
(i.e. power loss just after downloading the archive but before unpacking it).
The ComputeSHA1 will not help because it looks at the archive and not the
unpacked folder.

[kjellander_chromium, 2015-01-27 09:59:30]

lgtm

[phoglund_chromium, 2015-01-27 10:16:58]

Committed patchset #3 (id:40001) manually as r293821 (presubmit successful).