Adding support for AppRTC closure compiling.

download_node.py

+#!/usr/bin/python
+# Copyright 2014 The Chromium Authors. All rights reserved.

[kjellander_chromium, 2015/01/27 09:32:57]

2015

[phoglund_chromium, 2015/01/27 09:49:38]

Done.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Downloads the node binaries from WebRTC storage and unpacks it.
+
+Requires that depot_tools is installed and in the PATH. This script expects
+to run with Chrome's base dir as the working directory, e.g. where the .gclient
+file is. This is what should happen if this script is invoked as a hook action.
+"""
+
+import glob
+import os
+import sys
+import tarfile
+import zipfile
+
+import utils
+
+
+def _GetNodeArchivePathForPlatform():
+  archive_extension = 'zip' if utils.GetPlatform() == 'win' else 'tar.gz'
+  return os.path.join(utils.GetPlatform(), 'node.%s' % archive_extension)
+
+
+def _StripVersionNumberFromNodeDir():
+  # The node dir will be called node-x-x-x.tar.gz, rename to just node.
+  unpacked_name = glob.glob('node*')
+  assert len(unpacked_name) == 1, 'Should have precisely one node!'
+  os.rename(unpacked_name[0], 'node')
+
+
+def main(argv):
+  if len(argv) == 1:
+    return 'Usage: %s <path to webrtc.DEPS>' % argv[0]
+  if not os.path.exists('.gclient'):
+    return 'Invoked from wrong dir; invoke from dir with .gclient'
+
+  webrtc_deps_path = argv[1]

[kjellander_chromium, 2015/01/27 09:32:56]

A lot of this is duplicated in download_golang.py. I think you could extract a
helper function to put in utils.py, but I'll leave that as an optional
improvement.

[phoglund_chromium, 2015/01/27 09:49:38]

Yes, I feel a lot of the duplication is incidental, and I think there's a
possibility these will diverge anyway. I would have a hard time naming the
helper function
(DownloadArchivesWithAutoPlatformIfNecessaryAndUnpackAndReplaceWithVersionNumberStrippedFromArchiveName)?

+  node_path = os.path.join(webrtc_deps_path, 'node')
+  archive_path = os.path.join(node_path, _GetNodeArchivePathForPlatform())
+  old_archive_sha1 = utils.ComputeSHA1(archive_path)
+
+  utils.DownloadFilesFromGoogleStorage(node_path)
+
+  if (old_archive_sha1 != utils.ComputeSHA1(archive_path)
+      or not os.path.exists('node')):

[kjellander_chromium, 2015/01/27 09:32:57]

Do you need to check for non-existing node dir here? 
utils.ComputeSHA1 will return 0 for non-existing archive (which is how the
download_golang.py deals with that case).

[phoglund_chromium, 2015/01/27 09:49:38]

Ah, I should do this in download_golang too. The problem is mainly during
development if the archive gets downloaded but not unpacked, the script will do
nothing and leave us in a bad state which must be recovered from manually. I
added that check out of convenience and in case the bots get into that state
(i.e. power loss just after downloading the archive but before unpacking it).
The ComputeSHA1 will not help because it looks at the archive and not the
unpacked folder.

+    utils.DeleteDirNextToGclient('node')
+    utils.UnpackToWorkingDir(archive_path)
+    _StripVersionNumberFromNodeDir()
+
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))