[Ozone] Fix ui::Event::GetCharacter() when Ctrl is pressed

[Ozone] Fix ui::Event::GetCharacter() when Ctrl is pressed

On X11, ui::Event::GetCharacter() returns 0x0 when the correct return value
when control is pressed is unclear (e.g. Ctrl+[). This CL makes Ozone follow
the same behavior.

BUG=450849
TEST=Manual, see bug

Committed: https://crrev.com/15b15abda2de487cac0a8ddd9e06f35d88d52139
Cr-Commit-Position: refs/heads/master@{#313366}

[pkotwicz, 2015-01-25 01:04:16]

pkotwicz@chromium.org changed reviewers:
+ kpschoedel@chromium.org

[pkotwicz, 2015-01-25 01:04:17]

kpschoedel@ PTAL

[kpschoedel, 2015-01-26 19:34:22]

https://codereview.chromium.org/872213002/diff/1/ui/events/event.cc
File ui/events/event.cc (right):

https://codereview.chromium.org/872213002/diff/1/ui/events/event.cc#newcode783
ui/events/event.cc:783: #elif defined(USE_OZONE)
This code isn't run for normal key events (only for the "incomplete" synthetic
KeyEvent constructors used mostly by tests), and should soon go away (see
crbug.com/444045 and the discussion linked there). Ideally the keyboard layout
using xkb should be completely determined by the xkb layout configuration files
(in the xkeyboard-config package) but if there's a need to override that it
should be in XkbKeyboardLayoutEngine::Lookup(), so that it's applied
universally.

[pkotwicz, 2015-01-27 20:31:05]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2015-01-27 20:43:23]

kpschoedel@ can you please take another look?

I ended up calling GetCharacterFromKeyCode() from
XkbKeyboardLayoutEngine::Lookup()

I think you had something like this in mind:
bool ShouldIgnoreCharacterForKeyCode(ui::KeyboardCode key_code) {}

I made use of GetCharacterFromKeyCode() because:
- The input parameter needs to be a ui::KeyboardCode. (Because the conversion
needs to take keyboard layout into account)
- As per https://codereview.chromium.org/841263005/, it is ok for
xkb_keyboard_layout_engine.* to make use of keyboard_code_conversion.*

I have filed crbug.com/452619 to investigate whether the Ctrl keycode conversion
logic can be simplified

[pkotwicz, 2015-01-27 20:45:35]

Patchset #2 (id:40001) has been deleted

[kpschoedel, 2015-01-27 20:48:42]

The CQ bit was checked by kpschoedel@chromium.org

[kpschoedel, 2015-01-27 20:48:43]

lgtm

[kpschoedel, 2015-01-27 20:49:23]

The CQ bit was unchecked by kpschoedel@chromium.org

[kpschoedel, 2015-01-27 20:50:06]

kpschoedel@chromium.org changed reviewers:
+ spang@chromium.org

[kpschoedel, 2015-01-27 20:50:06]

+spang@ for ownership

[spang, 2015-01-27 20:51:34]

rubber stamp lgtm

[pkotwicz, 2015-01-27 21:00:04]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:01:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872213002/60001

[commit-bot: I haz the power, 2015-01-27 21:52:49]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-01-27 21:55:04]

Patchset 2 (id:??) landed as
https://crrev.com/15b15abda2de487cac0a8ddd9e06f35d88d52139
Cr-Commit-Position: refs/heads/master@{#313366}