Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

Issue 872213002: [Ozone] Fix ui::Event::GetCharacter() when Ctrl is pressed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h" 5 #include "ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h"
6 6
7 #include <xkbcommon/xkbcommon-names.h> 7 #include <xkbcommon/xkbcommon-names.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/single_thread_task_runner.h" 12 #include "base/single_thread_task_runner.h"
13 #include "base/task_runner.h" 13 #include "base/task_runner.h"
14 #include "base/thread_task_runner_handle.h" 14 #include "base/thread_task_runner_handle.h"
15 #include "base/threading/worker_pool.h" 15 #include "base/threading/worker_pool.h"
16 #include "ui/events/event_constants.h" 16 #include "ui/events/event_constants.h"
17 #include "ui/events/keycodes/dom3/dom_code.h" 17 #include "ui/events/keycodes/dom3/dom_code.h"
18 #include "ui/events/keycodes/dom3/dom_key.h" 18 #include "ui/events/keycodes/dom3/dom_key.h"
19 #include "ui/events/keycodes/dom4/keycode_converter.h" 19 #include "ui/events/keycodes/dom4/keycode_converter.h"
20 #include "ui/events/keycodes/keyboard_code_conversion.h"
20 #include "ui/events/ozone/layout/layout_util.h" 21 #include "ui/events/ozone/layout/layout_util.h"
21 #include "ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h" 22 #include "ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h"
22 23
23 namespace ui { 24 namespace ui {
24 25
25 namespace { 26 namespace {
26 27
27 typedef base::Callback<void(const std::string&, 28 typedef base::Callback<void(const std::string&,
28 scoped_ptr<char, base::FreeDeleter>)> 29 scoped_ptr<char, base::FreeDeleter>)>
29 LoadKeymapCallback; 30 LoadKeymapCallback;
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 *dom_key = NonPrintableXkbKeySymToDomKey(xkb_keysym); 768 *dom_key = NonPrintableXkbKeySymToDomKey(xkb_keysym);
768 if (*dom_key == DomKey::NONE) { 769 if (*dom_key == DomKey::NONE) {
769 *dom_key = CharacterToDomKey(*character); 770 *dom_key = CharacterToDomKey(*character);
770 *key_code = AlphanumericKeyboardCode(*character); 771 *key_code = AlphanumericKeyboardCode(*character);
771 if (*key_code == VKEY_UNKNOWN) { 772 if (*key_code == VKEY_UNKNOWN) {
772 *key_code = DifficultKeyboardCode(dom_code, flags, xkb_keycode, xkb_flags, 773 *key_code = DifficultKeyboardCode(dom_code, flags, xkb_keycode, xkb_flags,
773 xkb_keysym, *dom_key, *character); 774 xkb_keysym, *dom_key, *character);
774 if (*key_code == VKEY_UNKNOWN) 775 if (*key_code == VKEY_UNKNOWN)
775 *key_code = DomCodeToNonLocatedKeyboardCode(dom_code); 776 *key_code = DomCodeToNonLocatedKeyboardCode(dom_code);
776 } 777 }
778
779 if ((flags & EF_CONTROL_DOWN) == EF_CONTROL_DOWN) {
780 // Use GetCharacterFromKeyCode() to set |character| to 0x0 for key codes
781 // that we do not care about.
782 *character = GetCharacterFromKeyCode(*key_code, flags);
783 }
777 } else if (*dom_key == DomKey::DEAD) { 784 } else if (*dom_key == DomKey::DEAD) {
778 *character = DeadXkbKeySymToCombiningCharacter(xkb_keysym); 785 *character = DeadXkbKeySymToCombiningCharacter(xkb_keysym);
779 *key_code = DomCodeToNonLocatedKeyboardCode(dom_code); 786 *key_code = DomCodeToNonLocatedKeyboardCode(dom_code);
780 } else { 787 } else {
781 *key_code = NonPrintableDomKeyToKeyboardCode(*dom_key); 788 *key_code = NonPrintableDomKeyToKeyboardCode(*dom_key);
782 if (*key_code == VKEY_UNKNOWN) 789 if (*key_code == VKEY_UNKNOWN)
783 *key_code = DomCodeToNonLocatedKeyboardCode(dom_code); 790 *key_code = DomCodeToNonLocatedKeyboardCode(dom_code);
784 } 791 }
785 return true; 792 return true;
786 } 793 }
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
949 if (close_index == std::string::npos) 956 if (close_index == std::string::npos)
950 close_index = layout_name.size(); 957 close_index = layout_name.size();
951 *layout_variant = layout_name.substr(parentheses_index + 1, 958 *layout_variant = layout_name.substr(parentheses_index + 1,
952 close_index - parentheses_index - 1); 959 close_index - parentheses_index - 1);
953 } else if (dash_index != std::string::npos) { 960 } else if (dash_index != std::string::npos) {
954 *layout_id = layout_name.substr(0, dash_index); 961 *layout_id = layout_name.substr(0, dash_index);
955 *layout_variant = layout_name.substr(dash_index + 1); 962 *layout_variant = layout_name.substr(dash_index + 1);
956 } 963 }
957 } 964 }
958 } // namespace ui 965 } // namespace ui
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698