Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 872113003: Fix infobar scrolling. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix infobar scrolling. The infobar container became non-scrollable because InfoBarContainer now ignores all touch events in InfoBarContainer.onTouch(). These touch events need to be swallowed to prevent them from reaching the webpage, but they should be swallowed in ContentWrapperView, not in InfoBarContainer, so that InfoBarContainer (which extends ScrollView) can be scrolled. The offending CL: https://codereview.chromium.org/824763002 BUG=453103 Committed: https://crrev.com/7ef78075948121486f0061d3f75418d0dfda284c Cr-Commit-Position: refs/heads/master@{#313668}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-01-29 02:37:33 UTC) #2
newt (away)
PTAL again (looks like you lgtm'd the wrong CL before)
5 years, 10 months ago (2015-01-29 03:35:46 UTC) #3
aurimas (slooooooooow)
lgtm
5 years, 10 months ago (2015-01-29 04:23:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872113003/20001
5 years, 10 months ago (2015-01-29 04:43:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 05:19:42 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 05:20:52 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ef78075948121486f0061d3f75418d0dfda284c
Cr-Commit-Position: refs/heads/master@{#313668}

Powered by Google App Engine
This is Rietveld 408576698