Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 824763002: Fix bug where accessibility could "see behind" infobars. (Closed)

Created:
5 years, 12 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug where accessibility could "see behind" infobars. This swallows all hover events that are unhandled by an infobar before they reach the ContentView. This prevents a bug in accessibility mode where if the user clicked on an empty space in the infobar then an element from the webpage behind the infobar would be selected. BUG=430701 Committed: https://crrev.com/1ea31ca6935e488fdbb116bf81316cec1e7453bf Cr-Commit-Position: refs/heads/master@{#309454}

Patch Set 1 #

Total comments: 2

Patch Set 2 : "touch exploration mode" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
newt (away)
PTAL
5 years, 12 months ago (2014-12-22 18:28:15 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/824763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java (right): https://codereview.chromium.org/824763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java#newcode198 chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:198: // Consume all hover events so they do ...
5 years, 12 months ago (2014-12-22 19:10:48 UTC) #3
newt (away)
https://codereview.chromium.org/824763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java (right): https://codereview.chromium.org/824763002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java#newcode198 chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java:198: // Consume all hover events so they do not ...
5 years, 12 months ago (2014-12-22 19:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824763002/20001
5 years, 12 months ago (2014-12-22 19:14:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 12 months ago (2014-12-22 20:28:11 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1ea31ca6935e488fdbb116bf81316cec1e7453bf Cr-Commit-Position: refs/heads/master@{#309454}
5 years, 12 months ago (2014-12-22 20:30:38 UTC) #8
aurimas (slooooooooow)
5 years, 10 months ago (2015-01-29 02:38:19 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698