Chromium Code Reviews| Index: chrome/android/java/res/layout/autofill_credit_card_editor.xml |
| diff --git a/chrome/android/java/res/layout/autofill_credit_card_editor.xml b/chrome/android/java/res/layout/autofill_credit_card_editor.xml |
| index 6657b52fb54e383760cdd55634e37a10475dcea9..0fb71beb074644f71cde2e9a51e2ba405f15cfa5 100644 |
| --- a/chrome/android/java/res/layout/autofill_credit_card_editor.xml |
| +++ b/chrome/android/java/res/layout/autofill_credit_card_editor.xml |
| @@ -4,6 +4,7 @@ |
| found in the LICENSE file. --> |
| <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" |
| + xmlns:app="http://schemas.android.com/apk/res-auto" |
| android:layout_width="match_parent" |
| android:layout_height="match_parent" |
| android:fillViewport="true" |
| @@ -21,33 +22,37 @@ |
| android:orientation="vertical" |
| android:focusableInTouchMode="true" > |
| - <TextView |
| - style="@style/BoldTextFieldLabel" |
| - android:text="@string/autofill_credit_card_editor_name" /> |
| - |
| - <EditText |
| - android:id="@+id/autofill_credit_card_editor_name_edit" |
| + <org.chromium.chrome.browser.widget.FloatLabelLayout |
| android:layout_width="match_parent" |
| android:layout_height="wrap_content" |
| - android:imeOptions="flagNoExtractUi" |
| - android:contentDescription="@string/accessibility_autofill_cc_name_textbox" |
| - android:inputType="textCapWords" /> |
| - |
| - <TextView |
| - style="@style/BoldTextFieldLabel" |
| - android:text="@string/autofill_credit_card_editor_number" /> |
| + app:floatLabelTextAppearance="@style/PreferenceFloatLabelTextAppearance" > |
| + <EditText |
| + android:id="@+id/autofill_credit_card_editor_name_edit" |
| + android:layout_width="match_parent" |
| + android:layout_height="wrap_content" |
| + android:imeOptions="flagNoExtractUi" |
| + android:contentDescription="@string/accessibility_autofill_cc_name_textbox" |
|
newt (away)
2015/01/27 01:45:05
I believe that EditTexts shouldn't have contentDes
Theresa
2015/01/28 02:05:40
It still reads the actual contents of the text fie
|
| + android:inputType="textCapWords" |
| + android:hint="@string/autofill_credit_card_editor_name" /> |
| + </org.chromium.chrome.browser.widget.FloatLabelLayout> |
| - <EditText |
| - android:id="@+id/autofill_credit_card_editor_number_edit" |
| + <org.chromium.chrome.browser.widget.FloatLabelLayout |
| android:layout_width="match_parent" |
| - android:contentDescription="@string/accessibility_autofill_cc_number_textbox" |
| android:layout_height="wrap_content" |
| - android:imeOptions="flagNoExtractUi" |
| - android:inputType="phone" |
| - android:digits="0123456789- "/> |
| + app:floatLabelTextAppearance="@style/PreferenceFloatLabelTextAppearance" > |
| + <EditText |
| + android:id="@+id/autofill_credit_card_editor_number_edit" |
| + android:layout_width="match_parent" |
| + android:contentDescription="@string/accessibility_autofill_cc_number_textbox" |
| + android:layout_height="wrap_content" |
| + android:imeOptions="flagNoExtractUi" |
| + android:inputType="phone" |
| + android:digits="0123456789- " |
| + android:hint="@string/autofill_credit_card_editor_number" /> |
| + </org.chromium.chrome.browser.widget.FloatLabelLayout> |
| <TextView |
| - style="@style/BoldTextFieldLabel" |
| + style="@style/PreferenceTextFieldLabel" |
| android:text="@string/autofill_credit_card_editor_expiration_date" /> |
| <LinearLayout |