Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | 6 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" |
| 7 xmlns:app="http://schemas.android.com/apk/res-auto" | |
| 7 android:layout_width="match_parent" | 8 android:layout_width="match_parent" |
| 8 android:layout_height="match_parent" | 9 android:layout_height="match_parent" |
| 9 android:fillViewport="true" | 10 android:fillViewport="true" |
| 10 android:scrollbarStyle="outsideOverlay" > | 11 android:scrollbarStyle="outsideOverlay" > |
| 11 | 12 |
| 12 <LinearLayout | 13 <LinearLayout |
| 13 android:layout_width="match_parent" | 14 android:layout_width="match_parent" |
| 14 android:layout_height="wrap_content" | 15 android:layout_height="wrap_content" |
| 15 android:orientation="vertical" > | 16 android:orientation="vertical" > |
| 16 | 17 |
| 17 <LinearLayout | 18 <LinearLayout |
| 18 style="@style/PreferenceScreenLayout" | 19 style="@style/PreferenceScreenLayout" |
| 19 android:layout_width="match_parent" | 20 android:layout_width="match_parent" |
| 20 android:layout_height="wrap_content" | 21 android:layout_height="wrap_content" |
| 21 android:orientation="vertical" | 22 android:orientation="vertical" |
| 22 android:focusableInTouchMode="true" > | 23 android:focusableInTouchMode="true" > |
| 23 | 24 |
| 24 <TextView | 25 <org.chromium.chrome.browser.widget.FloatLabelLayout |
| 25 style="@style/BoldTextFieldLabel" | |
| 26 android:text="@string/autofill_credit_card_editor_name" /> | |
| 27 | |
| 28 <EditText | |
| 29 android:id="@+id/autofill_credit_card_editor_name_edit" | |
| 30 android:layout_width="match_parent" | 26 android:layout_width="match_parent" |
| 31 android:layout_height="wrap_content" | 27 android:layout_height="wrap_content" |
| 32 android:imeOptions="flagNoExtractUi" | 28 app:floatLabelTextAppearance="@style/PreferenceFloatLabelTextApp earance" > |
| 33 android:contentDescription="@string/accessibility_autofill_cc_na me_textbox" | 29 <EditText |
| 34 android:inputType="textCapWords" /> | 30 android:id="@+id/autofill_credit_card_editor_name_edit" |
| 31 android:layout_width="match_parent" | |
| 32 android:layout_height="wrap_content" | |
| 33 android:imeOptions="flagNoExtractUi" | |
| 34 android:contentDescription="@string/accessibility_autofill_c c_name_textbox" | |
|
newt (away)
2015/01/27 01:45:05
I believe that EditTexts shouldn't have contentDes
Theresa
2015/01/28 02:05:40
It still reads the actual contents of the text fie
| |
| 35 android:inputType="textCapWords" | |
| 36 android:hint="@string/autofill_credit_card_editor_name" /> | |
| 37 </org.chromium.chrome.browser.widget.FloatLabelLayout> | |
| 38 | |
| 39 <org.chromium.chrome.browser.widget.FloatLabelLayout | |
| 40 android:layout_width="match_parent" | |
| 41 android:layout_height="wrap_content" | |
| 42 app:floatLabelTextAppearance="@style/PreferenceFloatLabelTextApp earance" > | |
| 43 <EditText | |
| 44 android:id="@+id/autofill_credit_card_editor_number_edit" | |
| 45 android:layout_width="match_parent" | |
| 46 android:contentDescription="@string/accessibility_autofill_c c_number_textbox" | |
| 47 android:layout_height="wrap_content" | |
| 48 android:imeOptions="flagNoExtractUi" | |
| 49 android:inputType="phone" | |
| 50 android:digits="0123456789- " | |
| 51 android:hint="@string/autofill_credit_card_editor_number" /> | |
| 52 </org.chromium.chrome.browser.widget.FloatLabelLayout> | |
| 35 | 53 |
| 36 <TextView | 54 <TextView |
| 37 style="@style/BoldTextFieldLabel" | 55 style="@style/PreferenceTextFieldLabel" |
| 38 android:text="@string/autofill_credit_card_editor_number" /> | |
| 39 | |
| 40 <EditText | |
| 41 android:id="@+id/autofill_credit_card_editor_number_edit" | |
| 42 android:layout_width="match_parent" | |
| 43 android:contentDescription="@string/accessibility_autofill_cc_nu mber_textbox" | |
| 44 android:layout_height="wrap_content" | |
| 45 android:imeOptions="flagNoExtractUi" | |
| 46 android:inputType="phone" | |
| 47 android:digits="0123456789- "/> | |
| 48 | |
| 49 <TextView | |
| 50 style="@style/BoldTextFieldLabel" | |
| 51 android:text="@string/autofill_credit_card_editor_expiration_dat e" /> | 56 android:text="@string/autofill_credit_card_editor_expiration_dat e" /> |
| 52 | 57 |
| 53 <LinearLayout | 58 <LinearLayout |
| 54 android:layout_width="match_parent" | 59 android:layout_width="match_parent" |
| 55 android:layout_height="wrap_content" | 60 android:layout_height="wrap_content" |
| 56 android:orientation="horizontal" > | 61 android:orientation="horizontal" > |
| 57 | 62 |
| 58 <Spinner | 63 <Spinner |
| 59 android:id="@+id/autofill_credit_card_editor_month_spinner" | 64 android:id="@+id/autofill_credit_card_editor_month_spinner" |
| 60 android:layout_width="0dp" | 65 android:layout_width="0dp" |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 88 android:text="@string/cancel" /> | 93 android:text="@string/cancel" /> |
| 89 | 94 |
| 90 <Button | 95 <Button |
| 91 android:id="@+id/autofill_credit_card_save" | 96 android:id="@+id/autofill_credit_card_save" |
| 92 style="@style/ButtonBarButton" | 97 style="@style/ButtonBarButton" |
| 93 android:text="@string/save" /> | 98 android:text="@string/save" /> |
| 94 </LinearLayout> | 99 </LinearLayout> |
| 95 </LinearLayout> | 100 </LinearLayout> |
| 96 | 101 |
| 97 </ScrollView> | 102 </ScrollView> |
| OLD | NEW |