Use floating labels for preference forms

chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
new file mode 100644
index 0000000000000000000000000000000000000000..3482fb7c112bc4bb38df3c4cc45be937ef4698c8
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java
@@ -0,0 +1,68 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.autofill;
+
+import android.util.Pair;
+
+import org.chromium.base.CalledByNative;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Static methods to fetch information needed to create the address fields for the autofill profile
+ * form.
+ */
+public class AutofillProfileBridge {
+    /**
+     * @return A list of supported CLDR region codes.

[newt (away), 2015/01/28 20:20:18]

s/A/The

[Theresa, 2015/01/29 05:22:13]

Done.

+     */
+    public static List<String> getAvailableCountries() {

[newt (away), 2015/01/28 20:20:19]

for consistent terminology, how about calling this getCountryCodes() or
getSupportedCountryCodes()?

[Theresa, 2015/01/29 05:22:13]

Done, kind of. I changed it to getSupportedCountries() because this returns
country codes and names now.

+        List<String> countries = new ArrayList<String>();
+        nativeGetAvailableCountries(countries);
+        return countries;
+    }
+
+    /**
+     * Returns the UI components for the CLDR countryCode provided. The components will be in
+     * default or Latin order depending on the BCP 47 uiLanguageTag provided.
+     *
+     * @param countryCode The CLDR code used to retrieve address components.
+     * @param uiLanguageTag The current UI language; helps determine the field order
+     * @return A list containing pairs of strings, where the first element in the pair is the
+     *         component id corresponds to an AddressField enum value in address_field.h,
+     *         and the second element in the pair is the localized component name (intended
+     *         for use as labels in the UI).
+     */
+    public static List<Pair<Integer, String>> getAddressUiComponents(String countryCode,

[newt (away), 2015/01/28 20:20:18]

I'd make this package private instead of public. It's too ad-hoc to be public
IMO.

Here's another way you could write this method:

    static String[] getAddressUiComponenets(...)

where the return value is an array with 9 elements: one for each constant in
AddressField.java.

[Theresa, 2015/01/29 05:22:13]

I made it package protected. Just returning a String[] doesn't work because the
field ordering isn't maintained; the order of AddressField's in componentIds is
the order items should be displayed in the UI. I'll make that more clear in the
comment.

+            String uiLanguageTag) {
+        List<Integer> componentIds = new ArrayList<Integer>();
+        List<String> componentNames = new ArrayList<String>();
+        List<Pair<Integer, String>> uiComponents = new ArrayList<Pair<Integer, String>>();
+        nativeGetAddressUiComponents(countryCode, uiLanguageTag, componentIds, componentNames);
+        for (int i = 0; i < componentIds.size(); i++) {
+            uiComponents.add(new Pair<Integer, String>(componentIds.get(i), componentNames.get(i)));
+        }
+        return uiComponents;
+    }
+
+    @CalledByNative
+    private static void stringArrayToList(String[] array, List<String> list) {

[newt (away), 2015/01/28 20:20:18]

Similar methods actually already exist in jni_array.h, e.g. ToJavaArrayOfStrings

[Theresa, 2015/01/29 05:22:13]

Yes, I saw that method; it doesn't do what I want I don't think. The method is
primarily useful for returning a jojectArray. Since I need two lists of things
for getAvailableCountries() and getAddressUiComponents(), using
ToJavaArrayOfStrings to convert a std::vector to a String[] and returning
doesn't quite work. I could/should have used it before for
getAvailableCountries, but that method does more now.

There's also SetObjectArrayElement in jni.h that I could use to populate arrays
passed in from Java. I think this is also close to what I want, but I don't
think it quite works.  For getAvailableCountries, since the number of available
countries is unknown, I can't (properly) initialize the arrays on the Java side.
For getAddressUiComponents(), I do know the max # of fields, so I could use
SetObjectArrayElement and just keep appending items to the country_id and
country_names lists, but since I already need this method for
getAvailableCountries it seems simpler/more consistent to use it for
getAddressUiComponents too.

[newt (away), 2015/01/29 20:00:36]

Agreed. Sadly, despite the plethora of methods in jni_array.h, none of them are
applicable for this class now.

+        for (String s : array) {
+            list.add(s);
+        }
+    }
+
+    @CalledByNative
+    private static void intArrayToList(int[] array, List<Integer> list) {
+        for (int s : array) {
+            list.add(s);
+        }
+    }
+
+    private static native void nativeGetAvailableCountries(List<String> countries);
+    private static native void nativeGetAddressUiComponents(String countryCode,
+            String uiLanguageTag, List<Integer> componentIds, List<String> componentNames);
+}