Use floating labels for preference forms

chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AddressField.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AddressField.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AddressField.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AddressField.java
new file mode 100644
index 0000000000000000000000000000000000000000..9eda67094a8b61cc69343220471a5596499c1cdd
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AddressField.java
@@ -0,0 +1,29 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file is 1:1 mapping of the enum values found in
+// src/third_party/libaddressinput/src/cpp/include/libaddressinput/address_field.h
+
+package org.chromium.chrome.browser.preferences.autofill;
+
+/**
+ * Address field types, ordered by size, from largest to smallest.
+ *
+ * This file is a 1:1 mapping of the enum values found in
+ * src/third_party/libaddressinput/src/cpp/include/libaddressinput/address_field.h

[newt (away), 2015/01/28 20:20:18]

Trying to stay in sync with a third_party file is dangerous, since there's no
comment in address_field.h warning developers to update this file when they
update address_field.h. I'd only consider this acceptable if you have a unit
test (not just a TODO) that will break if these get out of sync.

Another option is to create your own copy of the AddressField enum in C++ and
Java, then map from libaddressinput's AddressField to your own AddressField in
autofill_profile_bridge.cc (like you were doing before, but using ints instead
of strings). You could use java_cpp_enum to make your own AddressField constants
identical between C++ and Java, or, since these enums are private to
AutofillProfileBridge, it would be OK to manually create an enum in C++ and a
list of ints in Java that are matching, with a comment in each place explaining
that they need to stay in sync.

[Theresa, 2015/01/29 05:22:13]

I went with creating a copy of the AddressField enum in C++ and Java and mapping
from libaddressinput's AddressField to my own AddressField. I forwent using
java_cpp_enum in part because I need the NUM_FIELDS class member on the Java
side. We should only have to update these fields if address_field.h changes
which should be infrequently, and there are notes in both
autofill_profile_bridge.cc and AutofillProfileBridge.java about keeping the
AddressField enum/class in sync.

+ * The static final int's here should be kept in sync with the enum values in address_field.h
+ *
+ * TODO(twellington): Add unit test ensuring this file and address_field.h are in sync.
+ */
+public class AddressField {

[newt (away), 2015/01/28 20:20:18]

This should probably be package private (or even an inner class inside
AutofillProfileBridge)

[Theresa, 2015/01/29 05:22:13]

Done.

+    public static final int COUNTRY = 0;
+    public static final int ADMIN_AREA = 1;
+    public static final int LOCALITY = 2;
+    public static final int DEPENDENT_LOCALITY = 3;
+    public static final int SORTING_CODE = 4;
+    public static final int POSTAL_CODE = 5;
+    public static final int STREET_ADDRESS = 6;
+    public static final int ORGANIZATION = 7;
+    public static final int RECIPIENT = 8;
+}