Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 871913003: Clamp 'zoom' in CSSToLengthConversionData. (Closed)

Created:
5 years, 11 months ago by andersr
Modified:
5 years, 10 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clamp 'zoom' in CSSToLengthConversionData. It's possible to reach a state of zoom=0 with compound application of a small zoom value. (See testcase). We should therefore handle this situation instead of asserting. BUG=450606 R=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189635

Patch Set 1 #

Patch Set 2 : Clamp zoom. (+rebase). #

Patch Set 3 : Also clamp setZoom. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A LayoutTests/fast/css/zoom-zero-crash.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/zoom-zero-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/CSSToLengthConversionData.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/CSSToLengthConversionData.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
andersr
5 years, 11 months ago (2015-01-23 12:51:20 UTC) #1
Timothy Loh
On 2015/01/23 12:51:20, andersr wrote: Sorry for the slow response; can we just clamp in ...
5 years, 10 months ago (2015-02-03 05:37:16 UTC) #2
andersr
On 2015/02/03 05:37:16, Timothy Loh wrote: > On 2015/01/23 12:51:20, andersr wrote: > > Sorry ...
5 years, 10 months ago (2015-02-03 12:42:21 UTC) #3
Timothy Loh
lgtm
5 years, 10 months ago (2015-02-06 01:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871913003/40001
5 years, 10 months ago (2015-02-06 09:50:39 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 11:56:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189635

Powered by Google App Engine
This is Rietveld 408576698