Source/core/css/CSSToLengthConversionData.cpp - Issue 871913003: Clamp 'zoom' in CSSToLengthConversionData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSToLengthConversionData.cpp

Issue 871913003: Clamp 'zoom' in CSSToLengthConversionData. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Also clamp setZoom. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSToLengthConversionData.cpp

diff --git a/Source/core/css/CSSToLengthConversionData.cpp b/Source/core/css/CSSToLengthConversionData.cpp

index 2e97cb814f3669646715e8894d83a4b31483e9a5..43f836cfa65036a66970ea59d0adba1af24c8972 100644

--- a/Source/core/css/CSSToLengthConversionData.cpp

+++ b/Source/core/css/CSSToLengthConversionData.cpp

@@ -77,10 +77,9 @@ CSSToLengthConversionData::CSSToLengthConversionData(const RenderStyle* style, c

: m_style(style)

, m_fontSizes(fontSizes)

, m_viewportSize(viewportSize)

- , m_zoom(zoom)

+ , m_zoom(clampTo<float>(zoom, std::numeric_limits<float>::denorm_min()))

{

ASSERT(m_style);

- ASSERT(zoom > 0);

}

CSSToLengthConversionData::CSSToLengthConversionData(const RenderStyle* style, const RenderStyle* rootStyle, const RenderView* renderView, float zoom)

« no previous file with comments | « Source/core/css/CSSToLengthConversionData.h ('k') | no next file » | no next file with comments »