Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 871843007: WebVTT: Updated handling of non-line-snapped cue positioning (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebVTT: Updated handling of non-line-snapped cue positioning Remove the last piece of code in VTTCue::calculateDisplayParameters() from an older spec. version. BUG=301580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 11 months ago (2015-01-26 15:49:24 UTC) #2
philipj_slow
lgtm
5 years, 11 months ago (2015-01-27 04:37:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871843007/1
5 years, 11 months ago (2015-01-27 04:38:07 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 04:41:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189002

Powered by Google App Engine
This is Rietveld 408576698