Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 871843007: WebVTT: Updated handling of non-line-snapped cue positioning (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.cpp
diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp
index 9a51cd49b08d9d7f58cd3831c76ba3252438b5fa..302d50aa43e57862970fac7a7005b6321499e435 100644
--- a/Source/core/html/track/vtt/VTTCue.cpp
+++ b/Source/core/html/track/vtt/VTTCue.cpp
@@ -756,21 +756,6 @@ VTTDisplayParameters VTTCue::calculateDisplayParameters() const
displayParameters.position.setX(0);
}
- // FIXME: Remove this block.
- if (!m_snapToLines) {
- if (m_writingDirection == Horizontal && displayParameters.direction == CSSValueLtr)
- displayParameters.position.setX(computedTextPosition);
-
- if (m_writingDirection == Horizontal && displayParameters.direction == CSSValueRtl)
- displayParameters.position.setX(100 - computedTextPosition);
-
- if (m_writingDirection == VerticalGrowingLeft)
- displayParameters.position = FloatPoint(100 - computedLinePosition, computedTextPosition);
-
- if (m_writingDirection == VerticalGrowingRight)
- displayParameters.position.setY(computedTextPosition);
- }
-
// Step 9 not implemented (margin == 0).
ASSERT(std::isfinite(displayParameters.size));
« no previous file with comments | « LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698