Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 871453004: Add pdfium_embeddertests to BUILD.gn (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Bo Xu, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@embeddertest_compile
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add pdfium_embeddertests to BUILD.gn This brings BUILD.gn into equivalence with pdfium.gyp. Blocked on https://codereview.chromium.org/851283006/ R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/af9be4fe77e1067f1cc265de8aae547f6358bc44

Patch Set 1 #

Patch Set 2 : Patch regenerated for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Please review.
5 years, 11 months ago (2015-01-22 22:18:10 UTC) #2
Tom Sepez
Adding Lei in place of jam@. Please review.
5 years, 11 months ago (2015-01-23 00:48:39 UTC) #4
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-23 01:10:15 UTC) #5
Tom Sepez
5 years, 11 months ago (2015-01-23 01:26:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
af9be4fe77e1067f1cc265de8aae547f6358bc44 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698