Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 851283006: Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA. Currently, this is a difference between the standalone pdfium environment vs. pdfium as part of a chromium checkout. Locating the external data files is a nusiance when you don't have the binary's argv[0] line, so we create a new main that preserves this for us. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/36faa4ac92100936d108354a066218d1aae327a3

Patch Set 1 #

Patch Set 2 : One less ifdef #

Total comments: 1

Patch Set 3 : global in anonymous namespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 2 5 chunks +21 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
John, please review. This would block a pdfium roll, should one be required.
5 years, 11 months ago (2015-01-22 20:45:13 UTC) #2
Tom Sepez
I'm guessing jam@ is overloaded, so adding Lei. Please review.
5 years, 11 months ago (2015-01-23 00:47:37 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/851283006/diff/20001/testing/embedder_test.h File testing/embedder_test.h (right): https://codereview.chromium.org/851283006/diff/20001/testing/embedder_test.h#newcode71 testing/embedder_test.h:71: static const char* g_exe_path_; Just put this in ...
5 years, 11 months ago (2015-01-23 01:10:11 UTC) #5
Tom Sepez
On 2015/01/23 01:10:11, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/851283006/diff/20001/testing/embedder_test.h > File testing/embedder_test.h (right): ...
5 years, 11 months ago (2015-01-23 01:15:41 UTC) #6
Tom Sepez
5 years, 11 months ago (2015-01-23 01:18:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
36faa4ac92100936d108354a066218d1aae327a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698