Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871373015: De-Client Surface interface (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

De-Client Surface interface mojo.Surface's client had two methods: *) SetIdNamespace replaced by mojo.Surface.GetIdNamespace which returns the id namespace via a callback. *) ReturnResources split into a ResourceReturner interface which can be (optionally) set on the mojo.Surface via mojo.Surface.SetResourceReturner Also beefed up the comments a bit. BUG=451319 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/86e3d33fcfc1b985ca0b72486a5badc9facb6e92

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -91 lines) Patch
M examples/bitmap_uploader/bitmap_uploader.h View 3 chunks +4 lines, -3 lines 1 comment Download
M examples/bitmap_uploader/bitmap_uploader.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M examples/ganesh_app/texture_uploader.h View 3 chunks +4 lines, -3 lines 1 comment Download
M examples/ganesh_app/texture_uploader.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M examples/surfaces_app/child_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M examples/surfaces_app/surfaces_app.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M mojo/services/surfaces/public/interfaces/surfaces.mojom View 1 chunk +16 lines, -9 lines 0 comments Download
M services/fake_surfaces/fake_surfaces_service_application.cc View 3 chunks +14 lines, -5 lines 1 comment Download
M services/native_viewport/viewport_surface.h View 2 chunks +2 lines, -7 lines 0 comments Download
M services/native_viewport/viewport_surface.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M services/surfaces/surfaces_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M services/surfaces/surfaces_impl.cc View 4 chunks +11 lines, -4 lines 0 comments Download
M services/view_manager/display_manager.h View 2 chunks +1 line, -5 lines 0 comments Download
M services/view_manager/display_manager.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M sky/compositor/surface_holder.h View 3 chunks +4 lines, -3 lines 0 comments Download
M sky/compositor/surface_holder.cc View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
5 years, 10 months ago (2015-01-31 00:37:04 UTC) #2
sky
LGTM https://codereview.chromium.org/871373015/diff/1/examples/bitmap_uploader/bitmap_uploader.h File examples/bitmap_uploader/bitmap_uploader.h (right): https://codereview.chromium.org/871373015/diff/1/examples/bitmap_uploader/bitmap_uploader.h#newcode49 examples/bitmap_uploader/bitmap_uploader.h:49: // ResourceReturner implementation. nit: newline between 48/49. https://codereview.chromium.org/871373015/diff/1/examples/ganesh_app/texture_uploader.h ...
5 years, 10 months ago (2015-01-31 01:25:28 UTC) #3
jamesr
5 years, 10 months ago (2015-01-31 01:44:48 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
86e3d33fcfc1b985ca0b72486a5badc9facb6e92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698