Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 871063002: Use a trampoline stub to load the type feedback vector for CallICs. (Closed)

Created:
5 years, 11 months ago by mvstanton
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a trampoline stub to load the type feedback vector for CallICs. BUG= Committed: https://crrev.com/2a567faa3e7242359e29c63f8dc8c18104af0610 Cr-Commit-Position: refs/heads/master@{#26290}

Patch Set 1 : Basic change. #

Patch Set 2 : REBASE. #

Patch Set 3 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -26 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 4 chunks +16 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 4 chunks +16 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/code-stubs.h View 3 chunks +38 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 4 chunks +16 lines, -4 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ic/ic.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 4 chunks +16 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mvstanton
Hi Toon, Here is the mechanical change to introduce the trampoline step to CallICs, following ...
5 years, 11 months ago (2015-01-23 15:48:59 UTC) #3
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-27 10:06:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871063002/80001
5 years, 11 months ago (2015-01-27 10:59:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 11 months ago (2015-01-27 11:24:01 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 11:24:15 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a567faa3e7242359e29c63f8dc8c18104af0610
Cr-Commit-Position: refs/heads/master@{#26290}

Powered by Google App Engine
This is Rietveld 408576698