Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 871063002: Use a trampoline stub to load the type feedback vector for CallICs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2886 matching lines...) Expand 10 before | Expand all | Expand 10 after
2897 ZoneList<Expression*>* args = expr->arguments(); 2897 ZoneList<Expression*>* args = expr->arguments();
2898 int arg_count = args->length(); 2898 int arg_count = args->length();
2899 { PreservePositionScope scope(masm()->positions_recorder()); 2899 { PreservePositionScope scope(masm()->positions_recorder());
2900 for (int i = 0; i < arg_count; i++) { 2900 for (int i = 0; i < arg_count; i++) {
2901 VisitForStackValue(args->at(i)); 2901 VisitForStackValue(args->at(i));
2902 } 2902 }
2903 } 2903 }
2904 2904
2905 // Record source position of the IC call. 2905 // Record source position of the IC call.
2906 SetSourcePosition(expr->position()); 2906 SetSourcePosition(expr->position());
2907 Handle<Code> ic = CallIC::initialize_stub( 2907 Handle<Code> ic = CodeFactory::CallIC(isolate(), arg_count, call_type).code();
2908 isolate(), arg_count, call_type);
2909 __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackSlot()))); 2908 __ Move(edx, Immediate(SmiFromSlot(expr->CallFeedbackSlot())));
2910 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize)); 2909 __ mov(edi, Operand(esp, (arg_count + 1) * kPointerSize));
2911 // Don't assign a type feedback id to the IC, since type feedback is provided 2910 // Don't assign a type feedback id to the IC, since type feedback is provided
2912 // by the vector above. 2911 // by the vector above.
2913 CallIC(ic); 2912 CallIC(ic);
2914 2913
2915 RecordJSReturnSite(expr); 2914 RecordJSReturnSite(expr);
2916 2915
2917 // Restore context register. 2916 // Restore context register.
2918 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset)); 2917 __ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
(...skipping 2363 matching lines...) Expand 10 before | Expand all | Expand 10 after
5282 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5281 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5283 Assembler::target_address_at(call_target_address, 5282 Assembler::target_address_at(call_target_address,
5284 unoptimized_code)); 5283 unoptimized_code));
5285 return OSR_AFTER_STACK_CHECK; 5284 return OSR_AFTER_STACK_CHECK;
5286 } 5285 }
5287 5286
5288 5287
5289 } } // namespace v8::internal 5288 } } // namespace v8::internal
5290 5289
5291 #endif // V8_TARGET_ARCH_IA32 5290 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698