Chromium Code Reviews| Index: Source/modules/websockets/DOMWebSocketTest.cpp |
| diff --git a/Source/modules/websockets/DOMWebSocketTest.cpp b/Source/modules/websockets/DOMWebSocketTest.cpp |
| index e21e5a823cd8b34ab90b2f0b4b415790664b1af0..83be5bc0a9c9e8fdddf7d175055f71906d599ce1 100644 |
| --- a/Source/modules/websockets/DOMWebSocketTest.cpp |
| +++ b/Source/modules/websockets/DOMWebSocketTest.cpp |
| @@ -666,21 +666,28 @@ TEST_F(DOMWebSocketTest, binaryType) |
| { |
| EXPECT_EQ("blob", m_websocket->binaryType()); |
|
Nils Barth (inactive)
2015/04/02 14:56:35
BTW, could you remove these blank lines?
They're u
Paritosh Kumar
2015/04/02 15:41:32
I think, this space is between one operation call
Nils Barth (inactive)
2015/04/02 15:54:55
Ok, point taken.
(It's a bit loose spacing for my
Paritosh Kumar
2015/04/02 16:14:04
Thanks. Leaving this space.
|
| - m_websocket->setBinaryType("hoge"); |
| + m_websocket->setBinaryType("arraybuffer"); |
| + |
| + EXPECT_EQ("arraybuffer", m_websocket->binaryType()); |
| + |
| + m_websocket->setBinaryType("blob"); |
| EXPECT_EQ("blob", m_websocket->binaryType()); |
| +} |
| + |
| +class DOMWebSocketDeathTest : public DOMWebSocketTestBase, public ::testing::Test { |
| +public: |
| +}; |
| +TEST_F(DOMWebSocketDeathTest, binaryType) |
| +{ |
| m_websocket->setBinaryType("arraybuffer"); |
|
Nils Barth (inactive)
2015/04/02 14:56:35
Same for these lines.
|
| EXPECT_EQ("arraybuffer", m_websocket->binaryType()); |
| - m_websocket->setBinaryType("fuga"); |
| + EXPECT_DEATH(m_websocket->setBinaryType("hoge"), ""); |
|
Paritosh Kumar
2015/04/02 15:41:32
We can remove this space.
Nils Barth (inactive)
2015/04/02 15:54:55
Good point; could you? Thanks!
Paritosh Kumar
2015/04/02 16:14:04
Thanks Removed.
|
| EXPECT_EQ("arraybuffer", m_websocket->binaryType()); |
| - |
| - m_websocket->setBinaryType("blob"); |
| - |
| - EXPECT_EQ("blob", m_websocket->binaryType()); |
| } |
| // FIXME: We should add tests for suspend / resume. |