Use enum BinaryType for WebSocket.binaryType, instead of DOMString

Source/modules/websockets/DOMWebSocketTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/websockets/DOMWebSocket.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
@@ skipping 647 matching lines @@
 // FIXME: We should have Blob tests here.
 // We can't create a Blob because the blob registration cannot be mocked yet.
 
 // FIXME: We should add tests for bufferedAmount.
 
 // FIXME: We should add tests for data receiving.
 
 TEST_F(DOMWebSocketTest, binaryType)
 {
     EXPECT_EQ("blob", m_websocket->binaryType());
 

[Nils Barth (inactive), 2015/04/02 14:56:35]

BTW, could you remove these blank lines?
They're useless and nowhere else in this test uses them.

[Paritosh Kumar, 2015/04/02 15:41:32]

I think, this space is between one operation call and EXPECT_* macro.

[Nils Barth (inactive), 2015/04/02 15:54:55]

Ok, point taken.
(It's a bit loose spacing for my taste, but ok to leave as is.)

[Paritosh Kumar, 2015/04/02 16:14:04]

Thanks. Leaving this space.

-    m_websocket->setBinaryType("hoge");
-
-    EXPECT_EQ("blob", m_websocket->binaryType());
-
     m_websocket->setBinaryType("arraybuffer");
 
     EXPECT_EQ("arraybuffer", m_websocket->binaryType());
 
-    m_websocket->setBinaryType("fuga");
-
-    EXPECT_EQ("arraybuffer", m_websocket->binaryType());
-
     m_websocket->setBinaryType("blob");
 
     EXPECT_EQ("blob", m_websocket->binaryType());
 }
 
+class DOMWebSocketDeathTest : public DOMWebSocketTestBase, public ::testing::Test {
+public:
+};
+
+TEST_F(DOMWebSocketDeathTest, binaryType)
+{
+    m_websocket->setBinaryType("arraybuffer");
+

[Nils Barth (inactive), 2015/04/02 14:56:35]

Same for these lines.

+    EXPECT_EQ("arraybuffer", m_websocket->binaryType());
+
+    EXPECT_DEATH(m_websocket->setBinaryType("hoge"), "");
+

[Paritosh Kumar, 2015/04/02 15:41:32]

We can remove this space.

[Nils Barth (inactive), 2015/04/02 15:54:55]

Good point; could you? Thanks!

[Paritosh Kumar, 2015/04/02 16:14:04]

Thanks Removed.

+    EXPECT_EQ("arraybuffer", m_websocket->binaryType());
+}
+
 // FIXME: We should add tests for suspend / resume.
 
 class DOMWebSocketValidClosingTest : public DOMWebSocketTestBase, public ::testing::TestWithParam<unsigned short> {
 public:
 };
 
 TEST_P(DOMWebSocketValidClosingTest, test)
 {
     {
         InSequence s;
@@ skipping 34 matching lines @@
     EXPECT_EQ(InvalidAccessError, m_exceptionState.code());
     EXPECT_EQ(String::format("The code must be either 1000, or between 3000 and 4999. %d is neither.", GetParam()), m_exceptionState.message());
     EXPECT_EQ(DOMWebSocket::CONNECTING, m_websocket->readyState());
 }
 
 INSTANTIATE_TEST_CASE_P(DOMWebSocketInvalidClosingCode, DOMWebSocketInvalidClosingCodeTest, ::testing::Values(0, 1, 998, 999, 1001, 2999, 5000, 9999, 65535));
 
 } // namespace
 
 } // namespace blink