Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 870883005: Apply use_non_zero_size_for_client_side_stream_buffers on PowerVR SGX 540 (Closed)

Created:
5 years, 11 months ago by kartikey
Modified:
5 years, 11 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply use_non_zero_size_for_client_side_stream_buffers on PowerVR SGX 540 On Imagination GPUs client side arrays are used for stream usage (GL_STREAM_DRAW) VBO. Service side makes glBufferData(target, 0, NULL, GL_STREAM_DRAW) calls to allow the driver to free any previous data assoicated with the buffer. However, drivers for Imagination PowerVR SGX 540 GPUs throw GL_OUT_OF_MEMORY error when glBufferData is called with buffer size of 0. BUG=451501 Committed: https://crrev.com/c182d80982c470ee4d34e9284611d45298b5e8c5 Cr-Commit-Position: refs/heads/master@{#312962}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
kartikey
Hi zmo, This is a proposed fix for crbug.com/451501. I have added you as a ...
5 years, 11 months ago (2015-01-23 19:10:41 UTC) #2
Zhenyao Mo
sievers: FYI https://codereview.chromium.org/870883005/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/870883005/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode1111 gpu/config/gpu_driver_bug_list_json.cc:1111: "description": "PowerVR SGX 540 drivers throw GL_OUT_OF_MEMORY ...
5 years, 11 months ago (2015-01-23 19:18:07 UTC) #3
kartikey
Added cr_bugs to keep track.
5 years, 11 months ago (2015-01-23 19:27:15 UTC) #4
Zhenyao Mo
LGTM
5 years, 11 months ago (2015-01-23 19:28:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870883005/20001
5 years, 11 months ago (2015-01-23 22:10:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 23:33:47 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 23:34:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c182d80982c470ee4d34e9284611d45298b5e8c5
Cr-Commit-Position: refs/heads/master@{#312962}

Powered by Google App Engine
This is Rietveld 408576698