chrome/browser/ui/autofill/chrome_autofill_client.cc - Issue 870833002: [android] Autofill popup behavior fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: MainFrameWasResized hides the popup only on Mac. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/chrome_autofill_client.cc

diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc

index 47b821982e33ad2042643c681b2a88a895fa6a4f..3ffe0035c39143946a4dbb1e5e93123b43cc435e 100644

--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc

+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc

@@ -220,7 +220,11 @@ void ChromeAutofillClient::DidNavigateAnyFrame(

}

void ChromeAutofillClient::MainFrameWasResized() {

+#if defined(OS_MACOSX)

+ // Views hides autofill popup in AutofillPopupBaseView::OnWidgetBoundsChanged.

Evan Stade 2015/01/23 22:28:00 maybe you can delete that code on views so we don'

please use gerrit instead 2015/01/26 18:51:14 Done.

+ // Android does not hide autofill popup on resize.

HideAutofillPopup();

+#endif // defined(OS_MACOSX)

}

void ChromeAutofillClient::WebContentsDestroyed() {

« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »