Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Side by Side Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: MainFrameWasResized hides the popup only on Mac. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/chrome_autofill_client.h" 5 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/autofill/personal_data_manager_factory.h" 9 #include "chrome/browser/autofill/personal_data_manager_factory.h"
10 #include "chrome/browser/infobars/infobar_service.h" 10 #include "chrome/browser/infobars/infobar_service.h"
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 213
214 void ChromeAutofillClient::DidNavigateAnyFrame( 214 void ChromeAutofillClient::DidNavigateAnyFrame(
215 content::RenderFrameHost* render_frame_host, 215 content::RenderFrameHost* render_frame_host,
216 const content::LoadCommittedDetails& details, 216 const content::LoadCommittedDetails& details,
217 const content::FrameNavigateParams& params) { 217 const content::FrameNavigateParams& params) {
218 if (dialog_controller_ && render_frame_host == last_rfh_to_rac_) 218 if (dialog_controller_ && render_frame_host == last_rfh_to_rac_)
219 HideRequestAutocompleteDialog(); 219 HideRequestAutocompleteDialog();
220 } 220 }
221 221
222 void ChromeAutofillClient::MainFrameWasResized() { 222 void ChromeAutofillClient::MainFrameWasResized() {
223 #if defined(OS_MACOSX)
224 // Views hides autofill popup in AutofillPopupBaseView::OnWidgetBoundsChanged.
Evan Stade 2015/01/23 22:28:00 maybe you can delete that code on views so we don'
please use gerrit instead 2015/01/26 18:51:14 Done.
225 // Android does not hide autofill popup on resize.
223 HideAutofillPopup(); 226 HideAutofillPopup();
227 #endif // defined(OS_MACOSX)
224 } 228 }
225 229
226 void ChromeAutofillClient::WebContentsDestroyed() { 230 void ChromeAutofillClient::WebContentsDestroyed() {
227 HideAutofillPopup(); 231 HideAutofillPopup();
228 } 232 }
229 233
230 void ChromeAutofillClient::OnZoomChanged( 234 void ChromeAutofillClient::OnZoomChanged(
231 const ui_zoom::ZoomController::ZoomChangedEventData& data) { 235 const ui_zoom::ZoomController::ZoomChangedEventData& data) {
232 HideAutofillPopup(); 236 HideAutofillPopup();
233 } 237 }
(...skipping 22 matching lines...) Expand all
256 new AutofillMsg_FirstUserGestureObservedInTab(routing_id())); 260 new AutofillMsg_FirstUserGestureObservedInTab(routing_id()));
257 } 261 }
258 262
259 void ChromeAutofillClient::LinkClicked(const GURL& url, 263 void ChromeAutofillClient::LinkClicked(const GURL& url,
260 WindowOpenDisposition disposition) { 264 WindowOpenDisposition disposition) {
261 web_contents()->OpenURL(content::OpenURLParams( 265 web_contents()->OpenURL(content::OpenURLParams(
262 url, content::Referrer(), disposition, ui::PAGE_TRANSITION_LINK, false)); 266 url, content::Referrer(), disposition, ui::PAGE_TRANSITION_LINK, false));
263 } 267 }
264 268
265 } // namespace autofill 269 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698