Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update expectations of old test and add a new test. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index b0ff55a96ccd758599a314223dee9a1f1c041d61..04746c6004c4528e98f4ae06dea3db8c47c2c9bd 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -325,12 +325,6 @@ void AutofillAgent::FormControlElementClicked(
if (!single_click_autofill) {
// Show full suggestions when clicking on an already-focused form field. On
// the initial click (not focused yet), only show password suggestions.
-#if defined(OS_ANDROID)
- // TODO(gcasto): Remove after crbug.com/430318 has been fixed.
- if (!was_focused)
- return;
-#endif
-
options.show_full_suggestion_list =
options.show_full_suggestion_list || was_focused;
options.show_password_suggestions_only = !was_focused;
@@ -382,6 +376,7 @@ void AutofillAgent::TextFieldDidChangeImpl(
}
if (password_autofill_agent_->TextDidChangeInTextField(*input_element)) {
+ is_popup_possibly_visible_ = true;
element_ = element;
return;
}

Powered by Google App Engine
This is Rietveld 408576698