chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc - Issue 870833002: [android] Autofill popup behavior fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update expectations of old test and add a new test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/password_generation_popup_view_views.h ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

diff --git a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

index 3718db310bb3f8430b7e4b138b8502ed33ca7523..80fbf8ef39a808352252daa93353f01cb99bd4ea 100644

--- a/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

+++ b/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

@@ -119,8 +119,8 @@ class PasswordGenerationPopupViewViews::PasswordBox : public views::View {

PasswordGenerationPopupViewViews::PasswordGenerationPopupViewViews(

PasswordGenerationPopupController* controller,

- views::Widget* observing_widget)

- : AutofillPopupBaseView(controller, observing_widget),

+ views::FocusManager* focus_manager)

+ : AutofillPopupBaseView(controller, focus_manager),

password_view_(NULL),

font_list_(ResourceBundle::GetSharedInstance().GetFontList(

ResourceBundle::SmallFont)),

@@ -273,7 +273,8 @@ PasswordGenerationPopupView* PasswordGenerationPopupView::Create(

if (!observing_widget)

return NULL;

- return new PasswordGenerationPopupViewViews(controller, observing_widget);

+ return new PasswordGenerationPopupViewViews(

+ controller, observing_widget->GetFocusManager());

}

void PasswordGenerationPopupViewViews::GetAccessibleState(