chrome/browser/ui/autofill/chrome_autofill_client.cc - Issue 870833002: [android] Autofill popup behavior fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update expectations of old test and add a new test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/chrome_autofill_client.cc

diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc

index 47b821982e33ad2042643c681b2a88a895fa6a4f..7b804eed91c6bebd40ddb6f4a436a2790ea2d147 100644

--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc

+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc

@@ -219,7 +219,13 @@ void ChromeAutofillClient::DidNavigateAnyFrame(

HideRequestAutocompleteDialog();

}

-void ChromeAutofillClient::MainFrameWasResized() {

+void ChromeAutofillClient::MainFrameWasResized(bool width_changed) {

+#if defined(OS_ANDROID)

+ // Ignore virtual keyboard showing and hiding a strip of suggestions.

+ if (!width_changed)

+ return;

+#endif

HideAutofillPopup();

}