Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update expectations of old test and add a new test. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/chrome_autofill_client.h" 5 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/autofill/personal_data_manager_factory.h" 9 #include "chrome/browser/autofill/personal_data_manager_factory.h"
10 #include "chrome/browser/infobars/infobar_service.h" 10 #include "chrome/browser/infobars/infobar_service.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 } 212 }
213 213
214 void ChromeAutofillClient::DidNavigateAnyFrame( 214 void ChromeAutofillClient::DidNavigateAnyFrame(
215 content::RenderFrameHost* render_frame_host, 215 content::RenderFrameHost* render_frame_host,
216 const content::LoadCommittedDetails& details, 216 const content::LoadCommittedDetails& details,
217 const content::FrameNavigateParams& params) { 217 const content::FrameNavigateParams& params) {
218 if (dialog_controller_ && render_frame_host == last_rfh_to_rac_) 218 if (dialog_controller_ && render_frame_host == last_rfh_to_rac_)
219 HideRequestAutocompleteDialog(); 219 HideRequestAutocompleteDialog();
220 } 220 }
221 221
222 void ChromeAutofillClient::MainFrameWasResized() { 222 void ChromeAutofillClient::MainFrameWasResized(bool width_changed) {
223 #if defined(OS_ANDROID)
224 // Ignore virtual keyboard showing and hiding a strip of suggestions.
225 if (!width_changed)
226 return;
227 #endif
228
223 HideAutofillPopup(); 229 HideAutofillPopup();
224 } 230 }
225 231
226 void ChromeAutofillClient::WebContentsDestroyed() { 232 void ChromeAutofillClient::WebContentsDestroyed() {
227 HideAutofillPopup(); 233 HideAutofillPopup();
228 } 234 }
229 235
230 void ChromeAutofillClient::OnZoomChanged( 236 void ChromeAutofillClient::OnZoomChanged(
231 const ui_zoom::ZoomController::ZoomChangedEventData& data) { 237 const ui_zoom::ZoomController::ZoomChangedEventData& data) {
232 HideAutofillPopup(); 238 HideAutofillPopup();
(...skipping 23 matching lines...) Expand all
256 new AutofillMsg_FirstUserGestureObservedInTab(routing_id())); 262 new AutofillMsg_FirstUserGestureObservedInTab(routing_id()));
257 } 263 }
258 264
259 void ChromeAutofillClient::LinkClicked(const GURL& url, 265 void ChromeAutofillClient::LinkClicked(const GURL& url,
260 WindowOpenDisposition disposition) { 266 WindowOpenDisposition disposition) {
261 web_contents()->OpenURL(content::OpenURLParams( 267 web_contents()->OpenURL(content::OpenURLParams(
262 url, content::Referrer(), disposition, ui::PAGE_TRANSITION_LINK, false)); 268 url, content::Referrer(), disposition, ui::PAGE_TRANSITION_LINK, false));
263 } 269 }
264 270
265 } // namespace autofill 271 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/browser/ui/views/autofill/autofill_popup_base_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698