Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 870803002: minor readability / refactors (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
jvanverth1, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

minor readability / refactors I have been hacking at this test trying to understand why the N5 is still sometimes crashy (it seems, less but not zero now). No luck so far. But, while I've been reading and hacking at it, I think I've made a few small improvements, mostly to readability. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2f6bb6b85246314dd016ecf68bbfd9b48319117a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -41 lines) Patch
M tests/FloatingPointTextureTest.cpp View 3 chunks +23 lines, -41 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mtklein_C
5 years, 11 months ago (2015-01-22 23:01:01 UTC) #2
mtklein
Oh, actually, I think I was reading the buildbots wrong! It does look like that ...
5 years, 11 months ago (2015-01-22 23:02:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870803002/1
5 years, 11 months ago (2015-01-22 23:03:22 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 23:03:22 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-23 00:54:36 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 11 months ago (2015-01-23 06:54:41 UTC) #10
jvanverth1
lgtm
5 years, 11 months ago (2015-01-23 13:44:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870803002/1
5 years, 11 months ago (2015-01-23 13:47:43 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 13:47:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f6bb6b85246314dd016ecf68bbfd9b48319117a

Powered by Google App Engine
This is Rietveld 408576698