Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870743002: Allow unbudgeted resources to be recycled by the cache as scratch. (Closed)

Created:
5 years, 11 months ago by bsalomon
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@ckey
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow unbudgeted resources to be recycled by the cache as scratch. Committed: https://skia.googlesource.com/skia/+/c2f35b750a57d7dc0b8053a98279631d1ccb9b56

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -152 lines) Patch
M include/gpu/GrGpuResource.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 3 chunks +15 lines, -4 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 1 4 chunks +40 lines, -12 lines 1 comment Download
M src/gpu/GrTexture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 14 chunks +141 lines, -133 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
5 years, 11 months ago (2015-01-23 00:03:23 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/870743002/diff/60001/src/gpu/GrResourceCache2.cpp File src/gpu/GrResourceCache2.cpp (right): https://codereview.chromium.org/870743002/diff/60001/src/gpu/GrResourceCache2.cpp#newcode247 src/gpu/GrResourceCache2.cpp:247: Purgeable ?
5 years, 11 months ago (2015-01-23 14:54:10 UTC) #3
bsalomon
On 2015/01/23 14:54:10, robertphillips wrote: > lgtm > > https://codereview.chromium.org/870743002/diff/60001/src/gpu/GrResourceCache2.cpp > File src/gpu/GrResourceCache2.cpp (right): > ...
5 years, 11 months ago (2015-01-23 15:09:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870743002/60001
5 years, 11 months ago (2015-01-23 15:10:51 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 15:19:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c2f35b750a57d7dc0b8053a98279631d1ccb9b56

Powered by Google App Engine
This is Rietveld 408576698