Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: media/filters/renderer_impl.h

Issue 870693002: Require Renderer::Initialize() to return a status code via callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/filters/renderer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/renderer_impl.h
diff --git a/media/filters/renderer_impl.h b/media/filters/renderer_impl.h
index 6a65bc008da37299cbacad32d431a066ef488d1c..f84b3bfe3bc1db9bad793baff9a52a2031131a91 100644
--- a/media/filters/renderer_impl.h
+++ b/media/filters/renderer_impl.h
@@ -44,7 +44,7 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
// Renderer implementation.
void Initialize(DemuxerStreamProvider* demuxer_stream_provider,
- const base::Closure& init_cb,
+ const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
const BufferingStateCB& buffering_state_cb,
const PaintCB& paint_cb,
@@ -120,8 +120,6 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
// Callback executed when a runtime error happens.
void OnError(PipelineStatus error);
- void FireAllPendingCallbacks();
-
State state_;
// Task runner used to execute pipeline tasks.
@@ -137,7 +135,7 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
PaintCB paint_cb_;
// Temporary callback used for Initialize() and Flush().
- base::Closure init_cb_;
+ PipelineStatusCB init_cb_;
base::Closure flush_cb_;
scoped_ptr<AudioRenderer> audio_renderer_;
« no previous file with comments | « media/base/video_renderer.h ('k') | media/filters/renderer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698