media/base/video_renderer.h - Issue 870693002: Require Renderer::Initialize() to return a status code via callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/video_renderer.h

Issue 870693002: Require Renderer::Initialize() to return a status code via callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/video_renderer.h

diff --git a/media/base/video_renderer.h b/media/base/video_renderer.h

index 94196eb45996da3d5c6b251b61cabc48d2aede54..1e4433323e6c0bcf3fcafe0b8d365f4ad111b040 100644

--- a/media/base/video_renderer.h

+++ b/media/base/video_renderer.h

@@ -33,7 +33,8 @@ class MEDIA_EXPORT VideoRenderer {

virtual ~VideoRenderer();

// Initializes a VideoRenderer with |stream|, executing |init_cb| upon

- // completion.

+ // completion. If initialization fails, only |init_cb| (not |error_cb|) will

+ // be called.

// |set_decryptor_ready_cb| is fired when a Decryptor is needed, i.e. when the

// |stream| is encrypted.

@@ -49,7 +50,7 @@ class MEDIA_EXPORT VideoRenderer {

// |ended_cb| is executed when video rendering has reached the end of stream.

- // |error_cb| is executed if an error was encountered.

+ // |error_cb| is executed if an error was encountered after initialization.

// |get_time_cb| is used to query the current media playback time.

virtual void Initialize(DemuxerStream* stream,

« no previous file with comments | « media/base/renderer.h ('k') | media/filters/renderer_impl.h » ('j') | no next file with comments »