Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vaclav's review inputs. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index efda7d3cf91490ceb1242a884e301d2c7b13310e..494e934b34d4cb29361e681e48cf5ee19c40f0a2 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -282,6 +282,14 @@ class PasswordFormManager : public PasswordStoreConsumer {
const autofill::FormData& form_data,
const autofill::ServerFieldType& password_type);
+ // Returns true if |candidate|'s registry controlled domain for origin and
vabr (Chromium) 2015/02/02 14:18:50 Please update the comment. Also mention that |matc
Pritam Nikam 2015/02/05 06:12:07 Removed this function.
+ // password matches with one of the stored password form within
+ // |best_matches_|; otherwise false. On success, |matching_form| holds the
+ // matching password form.
+ bool HasMatchingCredentialsInStore(
+ const autofill::PasswordForm& candidate,
+ autofill::PasswordForm* matching_form) const;
+
// Set of PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most
// frequently require lookups by username value in IsNewLogin.

Powered by Google App Engine
This is Rietveld 408576698