[PasswordManager] Improve detection of ignorable change password forms.

components/password_manager/core/browser/password_form_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 264 matching lines @@
 
   // Remove possible_usernames that may contains sensitive information and
   // duplicates.
   void SanitizePossibleUsernames(autofill::PasswordForm* form);
 
   // Helper function to delegate uploading to the AutofillManager.
   virtual void UploadPasswordForm(
       const autofill::FormData& form_data,
       const autofill::ServerFieldType& password_type);
 
+  // Returns true if |candidate|'s registry controlled domain for origin and

[vabr (Chromium), 2015/02/02 14:18:50]

Please update the comment. Also mention that |matching_form| can be null.

[Pritam Nikam, 2015/02/05 06:12:07]

Removed this function.

+  // password matches with one of the stored password form within
+  // |best_matches_|; otherwise false. On success, |matching_form| holds the
+  // matching password form.
+  bool HasMatchingCredentialsInStore(
+      const autofill::PasswordForm& candidate,
+      autofill::PasswordForm* matching_form) const;
+
   // Set of PasswordForms from the DB that best match the form
   // being managed by this. Use a map instead of vector, because we most
   // frequently require lookups by username value in IsNewLogin.
   autofill::PasswordFormMap best_matches_;
 
   // Cleans up when best_matches_ goes out of scope.
   STLValueDeleter<autofill::PasswordFormMap> best_matches_deleter_;
 
   // The PasswordForm from the page or dialog managed by |this|.
   const autofill::PasswordForm observed_form_;
@@ skipping 58 matching lines @@
   ManagerAction manager_action_;
   UserAction user_action_;
   SubmitResult submit_result_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_