components/password_manager/core/browser/password_manager_unittest.cc - Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager_unittest.cc ('K') | « components/password_manager/core/browser/password_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index 22169b0eb3d047521aaebca44a459b866f5f800f..eb4814f9c630495f75eb9c3dd9e7774fb99ed16d 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -279,7 +279,10 @@ TEST_F(PasswordManagerTest, FormSubmitWithOnlyNewPasswordField) {

// This test is the same as FormSubmitEmptyStore, except that it simulates the

// user entering credentials into a sign-up form that only has a new password

// field.

+ std::vector<PasswordForm*> result; // Empty password store.

vabr (Chromium) 2015/02/10 18:54:57 Please revert the added lines 282 and 284-285, the

Pritam Nikam 2015/02/19 11:18:49 Done.

EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));

+ EXPECT_CALL(*store_.get(), GetLogins(_, _, _))

+ .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));

std::vector<PasswordForm> observed;

PasswordForm form(MakeFormWithOnlyNewPasswordField());

observed.push_back(form);