[PasswordManager] Improve detection of ignorable change password forms.

components/password_manager/core/browser/password_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_manager.h"
 
 #include <string>
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
@@ skipping 261 matching lines @@
   EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form)));
 
   // Simulate saving the form, as if the info bar was accepted.
   form_to_save->Save();
 }
 
 TEST_F(PasswordManagerTest, FormSubmitWithOnlyNewPasswordField) {
   // This test is the same as FormSubmitEmptyStore, except that it simulates the
   // user entering credentials into a sign-up form that only has a new password
   // field.
+  std::vector<PasswordForm*> result;  // Empty password store.

[vabr (Chromium), 2015/02/10 18:54:57]

Please revert the added lines 282 and 284-285, they are not needed any more. In
a recent change https://codereview.chromium.org/866983003/ I supplied the empty
store to all these tests by default.

[Pritam Nikam, 2015/02/19 11:18:49]

Done.

   EXPECT_CALL(driver_, FillPasswordForm(_)).Times(Exactly(0));
+  EXPECT_CALL(*store_.get(), GetLogins(_, _, _))
+      .WillOnce(DoAll(WithArg<2>(InvokeConsumer(result)), Return()));
   std::vector<PasswordForm> observed;
   PasswordForm form(MakeFormWithOnlyNewPasswordField());
   observed.push_back(form);
   manager()->OnPasswordFormsParsed(&driver_, observed);
   manager()->OnPasswordFormsRendered(&driver_, observed, true);
 
   // And the form submit contract is to call ProvisionallySavePassword.
   manager()->ProvisionallySavePassword(form);
 
   scoped_ptr<PasswordFormManager> form_to_save;
@@ skipping 636 matching lines @@
   manager()->ProvisionallySavePassword(form);
 
   scoped_ptr<PasswordFormManager> form_to_save;
   EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
       .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
 
   manager()->OnInPageNavigation(&driver_, form);
 }
 
 }  // namespace password_manager