components/bookmarks/browser/bookmark_utils.cc - Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_utils.cc

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the implementation of has_single_url() Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_utils.cc

diff --git a/components/bookmarks/browser/bookmark_utils.cc b/components/bookmarks/browser/bookmark_utils.cc

index 3a5c124b896f6eae03ffbc38940fcf2b34384f9f..e443053f3e1dfb865f06f303b7207720709145d7 100644

--- a/components/bookmarks/browser/bookmark_utils.cc

+++ b/components/bookmarks/browser/bookmark_utils.cc

@@ -258,7 +258,7 @@ void PasteFromClipboard(BookmarkModel* model,

index = parent->child_count();

ScopedGroupBookmarkActions group_paste(model);

- if (bookmark_data.elements.size() == 1 &&

+ if (bookmark_data.num_elements() == 1 &&

model->IsBookmarked(bookmark_data.elements[0].url)) {

MakeTitleUnique(model,

parent,