components/bookmarks/browser/bookmark_node_data_views.cc - Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_node_data_views.cc

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the implementation of has_single_url() Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_node_data_views.cc

diff --git a/components/bookmarks/browser/bookmark_node_data_views.cc b/components/bookmarks/browser/bookmark_node_data_views.cc

index 888ffccbb8a1d898142f654eefa8f98e39cc319b..136d80efe2927c6d7db3949c551c7e3e6a4e551e 100644

--- a/components/bookmarks/browser/bookmark_node_data_views.cc

+++ b/components/bookmarks/browser/bookmark_node_data_views.cc

@@ -34,7 +34,7 @@ void BookmarkNodeData::Write(const base::FilePath& profile_path,

// If there is only one element and it is a URL, write the URL to the

// clipboard.

- if (elements.size() == 1 && elements[0].is_url) {

+ if (has_single_url()) {

if (elements[0].url.SchemeIs(kJavaScriptScheme)) {

data->SetString(base::UTF8ToUTF16(elements[0].url.spec()));

} else {