Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/bookmarks/browser/bookmark_node_data.h

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the implementation of has_single_url() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_node_data.h
diff --git a/components/bookmarks/browser/bookmark_node_data.h b/components/bookmarks/browser/bookmark_node_data.h
index fd7d13d824980a0dc11bf18dabcc115e753d95bc..28140a86e055d8edd3aec79ab05b55412764edb4 100644
--- a/components/bookmarks/browser/bookmark_node_data.h
+++ b/components/bookmarks/browser/bookmark_node_data.h
@@ -149,11 +149,13 @@ struct BookmarkNodeData {
// Do we contain valid data?
bool is_valid() const { return !elements.empty(); }
- // Returns true if there is a single url.
- bool has_single_url() const { return is_valid() && elements[0].is_url; }
-
// Number of elements.
- size_t size() const { return elements.size(); }
sky 2015/01/26 16:23:41 It's more comment to use size() for members like t
tfarina 2015/01/28 16:32:54 Done.
+ size_t num_elements() const { return elements.size(); }
+
+ // Returns true if there is a single url.
+ bool has_single_url() const {
+ return num_elements() == 1 && elements[0].is_url;
+ }
// Clears the data.
void Clear();
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc ('k') | components/bookmarks/browser/bookmark_node_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698