Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bookmarks: BookmarkNodeData's size() cleanups. * Fix the implementation of has_single_url() method. It is incorrect to check is_valid() because the elements vector can contain more than 1 item. And thus the is_valid() check does not make sense, since it just check if the vector is not empty, not that it just contains one element. * Use is_valid() method when possible. * Use has_single_url() method when it makes sense. * Use data.size() to avoid a temp variable. BUG=None TEST=chrome still links and works as before, existing unit tests in components_unittests. R=sky@chromium.org Committed: https://crrev.com/b2ab3b4ff4a883fd6cd4efc31bec8990ad4fa249 Cr-Commit-Position: refs/heads/master@{#313702}

Patch Set 1 #

Patch Set 2 : chromeos fixes #

Patch Set 3 : linux fixes #

Patch Set 4 : elements.size() #

Patch Set 5 : fix the implementation of has_single_url() #

Total comments: 2

Patch Set 6 : size() #

Total comments: 2

Patch Set 7 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 1 2 3 4 5 6 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_node_data.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_node_data.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_unittest.cc View 1 2 3 4 5 8 chunks +8 lines, -8 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data_views.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_utils.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
tfarina
5 years, 11 months ago (2015-01-25 02:45:47 UTC) #1
sky
https://codereview.chromium.org/870293002/diff/80001/components/bookmarks/browser/bookmark_node_data.h File components/bookmarks/browser/bookmark_node_data.h (left): https://codereview.chromium.org/870293002/diff/80001/components/bookmarks/browser/bookmark_node_data.h#oldcode156 components/bookmarks/browser/bookmark_node_data.h:156: size_t size() const { return elements.size(); } It's more ...
5 years, 11 months ago (2015-01-26 16:23:41 UTC) #2
tfarina
https://codereview.chromium.org/870293002/diff/80001/components/bookmarks/browser/bookmark_node_data.h File components/bookmarks/browser/bookmark_node_data.h (left): https://codereview.chromium.org/870293002/diff/80001/components/bookmarks/browser/bookmark_node_data.h#oldcode156 components/bookmarks/browser/bookmark_node_data.h:156: size_t size() const { return elements.size(); } On 2015/01/26 ...
5 years, 10 months ago (2015-01-28 16:32:54 UTC) #3
sky
https://codereview.chromium.org/870293002/diff/100001/components/bookmarks/browser/bookmark_node_data.h File components/bookmarks/browser/bookmark_node_data.h (left): https://codereview.chromium.org/870293002/diff/100001/components/bookmarks/browser/bookmark_node_data.h#oldcode153 components/bookmarks/browser/bookmark_node_data.h:153: bool has_single_url() const { return is_valid() && elements[0].is_url; } ...
5 years, 10 months ago (2015-01-28 21:11:58 UTC) #4
tfarina
https://codereview.chromium.org/870293002/diff/100001/components/bookmarks/browser/bookmark_node_data.h File components/bookmarks/browser/bookmark_node_data.h (left): https://codereview.chromium.org/870293002/diff/100001/components/bookmarks/browser/bookmark_node_data.h#oldcode153 components/bookmarks/browser/bookmark_node_data.h:153: bool has_single_url() const { return is_valid() && elements[0].is_url; } ...
5 years, 10 months ago (2015-01-29 00:10:14 UTC) #6
sky
LGTM
5 years, 10 months ago (2015-01-29 02:49:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870293002/140001
5 years, 10 months ago (2015-01-29 14:18:30 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 10 months ago (2015-01-29 14:22:13 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 14:23:12 UTC) #11
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/b2ab3b4ff4a883fd6cd4efc31bec8990ad4fa249
Cr-Commit-Position: refs/heads/master@{#313702}

Powered by Google App Engine
This is Rietveld 408576698