components/bookmarks/browser/bookmark_node_data.h - Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_node_data.h

Issue 870293002: bookmarks: BookmarkNodeData's size() cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_node_data.h

diff --git a/components/bookmarks/browser/bookmark_node_data.h b/components/bookmarks/browser/bookmark_node_data.h

index fd7d13d824980a0dc11bf18dabcc115e753d95bc..c746f4937c217413c3aea3c7233485b994ba46b0 100644

--- a/components/bookmarks/browser/bookmark_node_data.h

+++ b/components/bookmarks/browser/bookmark_node_data.h

@@ -150,7 +150,7 @@ struct BookmarkNodeData {

bool is_valid() const { return !elements.empty(); }

// Returns true if there is a single url.

- bool has_single_url() const { return is_valid() && elements[0].is_url; }

+ bool has_single_url() const { return size() == 1 && elements[0].is_url; }

// Number of elements.

size_t size() const { return elements.size(); }