Issue 870173002: Merge to XFA: Fix null crash in CheckTrailer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 870173002: Merge to XFA: Fix null crash in CheckTrailer. (Closed)

Created:
5 years, 11 months ago by Tom Sepez

Modified:
5 years, 11 months ago

Reviewers:
Bo Xu

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix null crash in CheckTrailer. This includes: fa370ac Fix test naming in previous commit. e0bbe4a Fix null crash in CheckTrailer. TBR=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/2255a1bb3719b8492c795c8828d861bae037f6b9

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -4 lines)			Patch
M	BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A	fpdfsdk/src/fpdf_dataavail_embeddertest.cpp	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	testing/embedder_test.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	testing/resources/trailer_as_hexstring.in	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	testing/resources/trailer_as_hexstring.pdf	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	testing/resources/trailer_unterminated.in	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	testing/resources/trailer_unterminated.pdf	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Tom Sepez

5 years, 11 months ago (2015-01-23 23:33:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2255a1bb3719b8492c795c8828d861bae037f6b9 (presubmit successful).