Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(4)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: testing/resources/trailer_unterminated.in
Issue
870173002
:
Merge to XFA: Fix null crash in CheckTrailer. (Closed)
Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Bring in test rename,
Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
BUILD.gn
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
fpdfsdk/src/fpdf_dataavail_embeddertest.cpp
pdfium.gyp
testing/embedder_test.h
testing/resources/trailer_as_hexstring.in
testing/resources/trailer_as_hexstring.pdf
testing/resources/trailer_unterminated.in
testing/resources/trailer_unterminated.pdf
View unified diff
|
Download patch
« no previous file with comments
|
« testing/resources/trailer_as_hexstring.pdf
('k') |
testing/resources/trailer_unterminated.pdf »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{{header}}
2
{{object 1 0}} <<
3
/Type /Catalog
4
/Pages 2 0 R
5
/Names <<
6
/Dests 10 0 R
7
>>
8
/Dests 14 0 R
9
>>
10
endobj
11
{{object 2 0}} <<
12
/Type /Pages
13
/Count 1
14
/Kids [
15
3 0 R
16
]
17
>>
18
endobj
19
{{object 3 0}} <<
20
/Type /Page
21
/Parent 2 0 R
22
/MediaBox [0 0 612 792]
23
>>
24
endobj
25
{{xref}}
26
% closing angle-brackets not present for trailer dictionary.
27
trailer <<
28
/Size 6
29
/Root 1 0 R
30
{{startxref}}
31
%%EOF
OLD
NEW
« no previous file with comments
|
« testing/resources/trailer_as_hexstring.pdf
('k') |
testing/resources/trailer_unterminated.pdf »
('j') |
no next file with comments »
Issue 870173002: Merge to XFA: Fix null crash in CheckTrailer. (Closed)
Created 5 years, 11 months ago by Tom Sepez
Modified 5 years, 11 months ago
Reviewers: Bo Xu
Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Comments: 0
This is Rietveld
408576698