Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 870143003: Fix black background in website settings dropdown. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
Reviewers:
Ted C, sashab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix black background in website settings dropdown. The permission spinner in the website settings popup had a black background on certain devices. The bug was that the background was a defined using a <shape> element that didn't have a <solid> element inside of it (and certain devices default to a black fill color if <solid> isn't specified). Rather than fixing the immediate problem, this rewrites the code a bit: The line under the Spinner is now a View with 1dp height rather than the background of the Spinner's TextView. As a side-benefit, the underline now extends all the way to the right edge of the spinner. BUG=449643 Committed: https://crrev.com/168e275c4b6a6f0eb34cea473474fdeb997f588d Cr-Commit-Position: refs/heads/master@{#313833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -48 lines) Patch
M chrome/android/java/res/drawable/website_settings_permission_spinner_item.xml View 1 chunk +2 lines, -6 lines 0 comments Download
D chrome/android/java/res/drawable/website_settings_permission_spinner_item_background.xml View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/android/java/res/layout/website_settings_permission_row.xml View 1 chunk +25 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL screenshot on the bug: https://code.google.com/p/chromium/issues/detail?id=449643#c7
5 years, 10 months ago (2015-01-29 23:22:05 UTC) #2
Ted C
lgtm
5 years, 10 months ago (2015-01-29 23:24:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870143003/1
5 years, 10 months ago (2015-01-29 23:34:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 00:19:18 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 00:20:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/168e275c4b6a6f0eb34cea473474fdeb997f588d
Cr-Commit-Position: refs/heads/master@{#313833}

Powered by Google App Engine
This is Rietveld 408576698