Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4103)

Unified Diff: chrome/android/java/res/layout/website_settings_permission_row.xml

Issue 870143003: Fix black background in website settings dropdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/website_settings_permission_row.xml
diff --git a/chrome/android/java/res/layout/website_settings_permission_row.xml b/chrome/android/java/res/layout/website_settings_permission_row.xml
index 4095e839642f32fed5a09d87ed6420bdcdfae190..fdd4f2dbf0b0b37a0a0607b1294f624bd88ecdc6 100644
--- a/chrome/android/java/res/layout/website_settings_permission_row.xml
+++ b/chrome/android/java/res/layout/website_settings_permission_row.xml
@@ -1,39 +1,40 @@
<?xml version="1.0" encoding="utf-8"?>
-<!--
- Copyright 2014 The Chromium Authors. All rights reserved.
+<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
- Use of this source code is governed by a BSD-style license that can be
- found in the LICENSE file.
--->
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:orientation="horizontal"
android:paddingTop="18dp" >
<ImageView
android:id="@+id/website_settings_permission_icon"
android:layout_width="@dimen/website_settings_popup_permission_icon_size"
- android:layout_height="@dimen/website_settings_popup_permission_icon_size" />
+ android:layout_height="@dimen/website_settings_popup_permission_icon_size"
+ android:layout_marginEnd="16dp" />
- <LinearLayout
+ <TextView
+ android:id="@+id/website_settings_permission_name"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:orientation="vertical"
- android:paddingStart="16dp" >
+ android:layout_toEndOf="@id/website_settings_permission_icon"
+ android:textColor="#444444"
+ android:textSize="14sp"
+ android:textStyle="bold" />
- <TextView
- android:id="@+id/website_settings_permission_name"
- android:layout_width="match_parent"
- android:layout_height="wrap_content"
- android:textColor="#444444"
- android:textSize="14sp"
- android:textStyle="bold" />
+ <Spinner
+ android:id="@+id/website_settings_permission_spinner"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_toEndOf="@id/website_settings_permission_icon"
+ android:layout_below="@id/website_settings_permission_name" />
- <Spinner
- android:id="@+id/website_settings_permission_spinner"
- android:layout_width="match_parent"
- android:layout_height="wrap_content" />
- </LinearLayout>
+ <View
+ android:layout_width="match_parent"
+ android:layout_height="1dp"
+ android:layout_toEndOf="@id/website_settings_permission_icon"
+ android:layout_below="@id/website_settings_permission_spinner"
+ android:background="#e5e5e5" />
-</LinearLayout>
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698