Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1947)

Unified Diff: content/child/blink_platform_impl.h

Issue 870053006: Provides a second version of addTraceEvent that accepts a timestamp. This is in preparation for the… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed pre-processor branching at japhet's suggestion. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/blink_platform_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/blink_platform_impl.h
diff --git a/content/child/blink_platform_impl.h b/content/child/blink_platform_impl.h
index 46f39c426beb94015f20989bf26953e64febb094..d14c49c5651c28ecdd90deb3875e337bafc2ed1d 100644
--- a/content/child/blink_platform_impl.h
+++ b/content/child/blink_platform_impl.h
@@ -99,6 +99,33 @@ class CONTENT_EXPORT BlinkPlatformImpl
virtual const unsigned char* getTraceCategoryEnabledFlag(
const char* category_name);
virtual long* getTraceSamplingState(const unsigned thread_bucket);
+
jam 2015/01/28 23:31:09 nit: remove. when we implement an interface, we ad
charliea_google.com 2015/01/28 23:34:36 Done.
+ virtual TraceEventHandle addTraceEvent(
+ char phase,
+ const unsigned char* category_group_enabled,
+ const char* name,
+ unsigned long long id,
+ double timestamp,
+ int num_args,
+ const char** arg_names,
+ const unsigned char* arg_types,
+ const unsigned long long* arg_values,
+ unsigned char flags);
+ virtual TraceEventHandle addTraceEvent(
+ char phase,
+ const unsigned char* category_group_enabled,
+ const char* name,
+ unsigned long long id,
+ double timestamp,
+ int num_args,
+ const char** arg_names,
+ const unsigned char* arg_types,
+ const unsigned long long* arg_values,
+ const blink::WebConvertableToTraceFormat* convertable_values,
+ unsigned char flags);
+
+ // TODO(charliea): Remove the addTraceEvent methods without timestamps
+ // once Blink uses the new signature with timestamps
virtual TraceEventHandle addTraceEvent(
char phase,
const unsigned char* category_group_enabled,
@@ -120,6 +147,7 @@ class CONTENT_EXPORT BlinkPlatformImpl
const unsigned long long* arg_values,
const blink::WebConvertableToTraceFormat* convertable_values,
unsigned char flags);
+
jam 2015/01/28 23:31:09 ditto
charliea_google.com 2015/01/28 23:34:36 Done.
virtual void updateTraceEventDuration(
const unsigned char* category_group_enabled,
const char* name,
« no previous file with comments | « no previous file | content/child/blink_platform_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698