Provides a second version of addTraceEvent that accepts a timestamp. This is in preparation for the…

content/child/blink_platform_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_BLINK_PLATFORM_IMPL_H_
 #define CONTENT_CHILD_BLINK_PLATFORM_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/debug/trace_event.h"
 #include "base/threading/thread_local_storage.h"
@@ skipping 81 matching lines @@
   virtual void decrementStatsCounter(const char* name);
   virtual void incrementStatsCounter(const char* name);
   virtual void histogramCustomCounts(
     const char* name, int sample, int min, int max, int bucket_count);
   virtual void histogramEnumeration(
     const char* name, int sample, int boundary_value);
   virtual void histogramSparse(const char* name, int sample);
   virtual const unsigned char* getTraceCategoryEnabledFlag(
       const char* category_name);
   virtual long* getTraceSamplingState(const unsigned thread_bucket);
+

[jam, 2015/01/28 23:31:09]

nit: remove. when we implement an interface, we add the methods without spaces
in between

[charliea_google.com, 2015/01/28 23:34:36]

Done.

   virtual TraceEventHandle addTraceEvent(
       char phase,
       const unsigned char* category_group_enabled,
+      const char* name,
+      unsigned long long id,
+      double timestamp,
+      int num_args,
+      const char** arg_names,
+      const unsigned char* arg_types,
+      const unsigned long long* arg_values,
+      unsigned char flags);
+  virtual TraceEventHandle addTraceEvent(
+      char phase,
+      const unsigned char* category_group_enabled,
+      const char* name,
+      unsigned long long id,
+      double timestamp,
+      int num_args,
+      const char** arg_names,
+      const unsigned char* arg_types,
+      const unsigned long long* arg_values,
+      const blink::WebConvertableToTraceFormat* convertable_values,
+      unsigned char flags);
+
+  // TODO(charliea): Remove the addTraceEvent methods without timestamps
+  // once Blink uses the new signature with timestamps
+  virtual TraceEventHandle addTraceEvent(
+      char phase,
+      const unsigned char* category_group_enabled,
       const char* name,
       unsigned long long id,
       int num_args,
       const char** arg_names,
       const unsigned char* arg_types,
       const unsigned long long* arg_values,
       unsigned char flags);
   virtual TraceEventHandle addTraceEvent(
       char phase,
       const unsigned char* category_group_enabled,
       const char* name,
       unsigned long long id,
       int num_args,
       const char** arg_names,
       const unsigned char* arg_types,
       const unsigned long long* arg_values,
       const blink::WebConvertableToTraceFormat* convertable_values,
       unsigned char flags);
+

[jam, 2015/01/28 23:31:09]

ditto

[charliea_google.com, 2015/01/28 23:34:36]

Done.

   virtual void updateTraceEventDuration(
       const unsigned char* category_group_enabled,
       const char* name,
       TraceEventHandle);
   virtual blink::WebData loadResource(const char* name);
   virtual blink::WebString queryLocalizedString(
       blink::WebLocalizedString::Name name);
   virtual blink::WebString queryLocalizedString(
       blink::WebLocalizedString::Name name, int numeric_value);
   virtual blink::WebString queryLocalizedString(
@@ skipping 57 matching lines @@
   scoped_ptr<WebBluetoothImpl> bluetooth_;
 
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
   scoped_refptr<NotificationDispatcher> notification_dispatcher_;
   scoped_refptr<PushDispatcher> push_dispatcher_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_BLINK_PLATFORM_IMPL_H_