Don't use SK_ASSERT in header.

include/core/SkImageInfo.h

Index: include/core/SkImageInfo.h
diff --git a/include/core/SkImageInfo.h b/include/core/SkImageInfo.h
index 341ec143a2273e22fdc10fdf359c0098b326d114..5d6b1335702e7e401d9557f601a28ef5480d5f8b 100644
--- a/include/core/SkImageInfo.h
+++ b/include/core/SkImageInfo.h
@@ -105,8 +105,6 @@ static int SkColorTypeBytesPerPixel(SkColorType ct) {
     };
     SK_COMPILE_ASSERT(SK_ARRAY_COUNT(gSize) == (size_t)(kLastEnum_SkColorType + 1),
                       size_mismatch_with_SkColorType_enum);
-
-    SkASSERT((size_t)ct < SK_ARRAY_COUNT(gSize));

[dshwang, 2015/01/23 15:37:48]

I think this ASSERT is covered by above SK_COMPILE_ASSERT and c++ type system.

[bsalomon, 2015/01/23 15:55:50]

I believe the assert is to guard against the case when ct was unpacked from some
bitfield or whatnot and cast to SkColorType. The type system doesn't prevent you
from doing (SkColorType)(1 << 24).

The client is allowed to override SkDebugf but AFAIK the client is responsible
for ensuring that it is linked into anything that is built with skia headers.

     return gSize[ct];
 }