Don't use SK_ASSERT in header.

include/core/SkImageInfo.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkImageInfo_DEFINED
 #define SkImageInfo_DEFINED
 
@@ skipping 87 matching lines @@
         0,  // Unknown
         1,  // Alpha_8
         2,  // RGB_565
         2,  // ARGB_4444
         4,  // RGBA_8888
         4,  // BGRA_8888
         1,  // kIndex_8
     };
     SK_COMPILE_ASSERT(SK_ARRAY_COUNT(gSize) == (size_t)(kLastEnum_SkColorType + 1),
                       size_mismatch_with_SkColorType_enum);
-
-    SkASSERT((size_t)ct < SK_ARRAY_COUNT(gSize));

[dshwang, 2015/01/23 15:37:48]

I think this ASSERT is covered by above SK_COMPILE_ASSERT and c++ type system.

[bsalomon, 2015/01/23 15:55:50]

I believe the assert is to guard against the case when ct was unpacked from some
bitfield or whatnot and cast to SkColorType. The type system doesn't prevent you
from doing (SkColorType)(1 << 24).

The client is allowed to override SkDebugf but AFAIK the client is responsible
for ensuring that it is linked into anything that is built with skia headers.

     return gSize[ct];
 }
 
 static inline size_t SkColorTypeMinRowBytes(SkColorType ct, int width) {
     return width * SkColorTypeBytesPerPixel(ct);
 }
 
 static inline bool SkColorTypeIsValid(unsigned value) {
     return value <= kLastEnum_SkColorType;
 }
@@ skipping 178 matching lines @@
         , fHeight(height)
         , fColorType(ct)
         , fAlphaType(at)
         , fProfileType(pt)
     {}
 
     SkColorProfileType  fProfileType;
 };
 
 #endif