Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: Source/core/rendering/RenderBox.h

Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add minimumLogicalHeightForEmptyLine Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderBox.h
diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h
index 8dd3ebfe602a2094c9b300190f8f9e9ba03f3865..78c418079e72b4327278825c5b4d602f350027c0 100644
--- a/Source/core/rendering/RenderBox.h
+++ b/Source/core/rendering/RenderBox.h
@@ -108,6 +108,12 @@ public:
int pixelSnappedLogicalHeight() const { return style()->isHorizontalWritingMode() ? pixelSnappedHeight() : pixelSnappedWidth(); }
int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); }
+ LayoutUnit minimumLogicalHeightForEmptyLine() const
+ {
+ return borderAndPaddingLogicalHeight() + scrollbarLogicalHeight()
+ + lineHeight(true, isHorizontalWritingMode() ? HorizontalLine : VerticalLine, PositionOfInteriorLineBoxes);
+ }
rune 2015/02/26 10:38:50 You should now use this method in RenderFlexibleBo
changseok 2015/02/26 11:28:54 O.K
+
void setLogicalLeft(LayoutUnit left)
{
if (style()->isHorizontalWritingMode())

Powered by Google App Engine
This is Rietveld 408576698